Skip to content

Add Mobyt Notifier recipe #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Aug 14, 2020
Merged

Conversation

Deamon
Copy link
Contributor

@Deamon Deamon commented Apr 30, 2020

Q A
License MIT
Doc issue/PR symfony/symfony-docs#13606 / symfony/symfony#36648

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@YaFou
Copy link

YaFou commented Aug 10, 2020

The file shouldn't be in the folder 5.2?

@fabpot
Copy link
Member

fabpot commented Aug 10, 2020

Indeed.

@Deamon Deamon force-pushed the add-mobyt-notifier-recipe branch from b9797f6 to 2a788c7 Compare August 12, 2020 09:47
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@Deamon
Copy link
Contributor Author

Deamon commented Aug 12, 2020

@fabpot @YaFou, done :)

fabpot added a commit to symfony/symfony that referenced this pull request Aug 13, 2020
This PR was merged into the 5.2-dev branch.

Discussion
----------

[Notifier] Add Mobyt bridge

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |  #33687
| License       | MIT
| Doc PR        | symfony/symfony-docs#13606
| recipe PR   | symfony/recipes#768

Add Mobyt notifier bridge.

In this SMS Provider, you can choose a sort of "quality service" to send the message.

I updated `src/Symfony/Component/Notifier/Message/SmsMessage.php` to add the notification in order to be able to use the notification importance when creating options.

Commits
-------

bf594b7 Add Mobyt Notifier bridge
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Aug 13, 2020
This PR was merged into the 5.2-dev branch.

Discussion
----------

[Notifier] Add Mobyt bridge

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |  #33687
| License       | MIT
| Doc PR        | symfony/symfony-docs#13606
| recipe PR   | symfony/recipes#768

Add Mobyt notifier bridge.

In this SMS Provider, you can choose a sort of "quality service" to send the message.

I updated `src/Symfony/Component/Notifier/Message/SmsMessage.php` to add the notification in order to be able to use the notification importance when creating options.

Commits
-------

bf594b75d0 Add Mobyt Notifier bridge
@fabpot
Copy link
Member

fabpot commented Aug 14, 2020

@symfony-flex-server review again please

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge now

@ghost ghost merged commit 92886cd into symfony:master Aug 14, 2020
@Deamon Deamon deleted the add-mobyt-notifier-recipe branch August 17, 2020 13:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants